Aman-Mittal commented on PR #5465: URL: https://github.com/apache/fineract/pull/5465#issuecomment-3869304328
Ok, I think we can make ticket for this type of refractor. On Mon, 9 Feb, 2026, 10:24 am Saifulhuq, ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountTransactionsApiResource.java > <https://github.com/apache/fineract/pull/5465#discussion_r2780584266>: > > > @@ -193,6 +193,9 @@ public String ***@***.***("savingsId") final Long savingsId, @QueryPa > } else if (is(commandParam, "withdrawal")) { > final CommandWrapper commandRequest = builder.savingsAccountWithdrawal(savingsId).build(); > result = this.commandsSourceWritePlatformService.logCommandSource(commandRequest); > + } else if (is(commandParam, "force-withdrawal")) { > > This else if is becoming too long i think we can optimise this further > > @Aman-Mittal <https://github.com/Aman-Mittal> Valid point. This class > definitely relies heavily on the else-if chain pattern. > > However, for this specific PR, I intentionally stuck to the existing > pattern to ensure consistency with the surrounding code and to strictly > limit the sco0pe of changes to the "Force Withdrawal" feature. > > I am hesitant to refactor the command dispatch logic here as it would > require touching legacy paths (standard withdrawal/deposit) which increases > regression risk. I think a structural refactor would be better suited for a > dedicated "Technical Debt" PR. > > Does that sound reasonable? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/5465#discussion_r2780584266>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHV6TA43A7T7M4ANBDGZ6334LAHJLAVCNFSM6AAAAACULZBWYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONZRGE2DQMJXGQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
