edk12564 commented on PR #5495: URL: https://github.com/apache/fineract/pull/5495#issuecomment-3918523203
> I dont think any of the changes are needed. > > The attached integration tests are green without messing with transaction boundaries, neither having the "cleanup". > > The maker-checker is fully rolled back, so no left over data. You can create datatable if it was rejected priorly. > > Kindly asking you to double check! Firstly, thank you adam for the review! I did as you said and double checked by running a few tests, both in MariaDB and Postgres. Can I ask what database you used to check the changes? I think the database matters because the issue should only affect MariaDB. To clarify, the behavior of the solution and tests with a Postgres database should be a "no-op". This is because of how MariaDB handles DDL statements like creating new tables. So the problem doesn't even occur when Postgres databases are used. I tried to replicate in a few circumstances and got the results below. MariaDB (without cleanup): <img width="1107" height="532" alt="Screenshot 2026-02-17 at 10 06 49 PM" src="https://github.com/user-attachments/assets/38f9cd95-1811-461f-9765-115611dc66b0"; /> MariaDB (with cleanup): <img width="1093" height="547" alt="Screenshot 2026-02-17 at 10 19 26 PM" src="https://github.com/user-attachments/assets/7ad506c2-b6d2-4d4e-83e4-641d7c9f2ee8"; /> Postgres: <img width="1094" height="548" alt="Screenshot 2026-02-17 at 10 07 51 PM" src="https://github.com/user-attachments/assets/edbe09b3-aa1e-4fe1-a0c8-608ad0613735"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
