adamsaghy commented on code in PR #5495:
URL: https://github.com/apache/fineract/pull/5495#discussion_r2826904809
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/PortfolioCommandSourceWritePlatformServiceImpl.java:
##########
@@ -49,6 +50,7 @@ public class PortfolioCommandSourceWritePlatformServiceImpl
implements Portfolio
private final CommandProcessingService processAndLogCommandService;
private final SchedulerJobRunnerReadService schedulerJobRunnerReadService;
private final ConfigurationDomainService configurationService;
+ private final DatatableRejectionCleanupService
ifDatatableRejectionThenCleanup;
Review Comment:
Lets rename it something more generic, like: CleanUpService and have it as
an interface only. Lets inject it as a List, so multiple implementations are
allowed to be used (even if there is just one for now). If the list is null, we
can skip it. if not a foreach we can call all of them. The implementation
classes responsibilities to decide whether there is something to be done or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
