AshharAhmadKhan commented on PR #5491:
URL: https://github.com/apache/fineract/pull/5491#issuecomment-3977114618
@adamsaghy @IOhacker — did a proper investigation into every failing check
with run IDs and logs. All 8 failures are pre-existing on `develop` itself
right now. Here's the proof.
---
**1. `verify (build-core, main)` — Eclipse SWT**
Our run `22508750267` fails with:
```
[ERROR] org.eclipse.platform:org.eclipse.swt.${osgi.platform} does not match
a valid id pattern
```
I pulled develop's own run `22514802811` (Feb 28 06:01 UTC, running on
`develop` branch directly) — identical error, identical line. This is a broken
Eclipse BIRT/SWT dependency that landed in `develop` via a recent commit. This
PR touches zero Java files and zero build configuration.
---
**2. API Backward Compatibility — R014/R016**
Our run `22508750278` flags R014 (`fund.name` removed) and R016
(`loanScheduleProcessingType.HORIZONTAL/VERTICAL` deleted).
I then pulled develop's own run `22517486475` (Feb 28 08:51 UTC, on branch
`bugfix/FINERACT-2512`, commit `a59f40f`) — same R014 and R016 rules, `BUILD
FAILED in 17s`. Completely different branch, completely different commit, same
failures.
The API compat check has had no successful run on the repo since Feb 26.
Every run since:
- `22517486475` → failure (Feb 28 08:51)
- `22517452983` → action_required (Feb 28 08:49)
- `22517415588` → action_required (Feb 28 08:46)
- `22514802810` → failure (Feb 28 06:01)
`fund.name` and `loanScheduleProcessingType` are Java/OpenAPI constructs.
There is no mechanism by which removing SQL rows from `0002_initial_data.xml`
and `0003_postgresql_specific_initial_data.xml` can delete an OpenAPI enum
value or a response attribute.
---
**3. `test-core-4` and `test-core-5`**
These fail with `Access denied for user 'runner'@'172.18.0.1' (using
password: NO)` — a DB auth failure on the runner, cascading from the broken
build. Meanwhile `test-core-1`, `test-core-2`, and `test-core-3` all pass on
this same PR across all three DB variants (MariaDB, MySQL, PostgreSQL). If this
were a code problem, all shards would fail equally.
---
**What this PR actually changes**
121 Pentaho SQL entries removed from `0002_initial_data.xml` and
`0003_postgresql_specific_initial_data.xml`. `validCheckSum="ANY"` added to the
three modified changesets. 52 `falsee` → `false` typos fixed. No Java, no API,
no schema, no Gradle.
**Checks that directly validate this PR all pass:**
| Check | Result |
|---|---|
| Verify Liquibase Backward Compatibility | ✅ |
| Fineract Build & Cucumber (all 3 variants) | ✅ |
| Fineract E2E Tests (all 10 shards) | ✅ |
| Docker Builds (both variants) | ✅ |
| Messaging Smoke Tests | ✅ |
| Liquibase Only mode — PostgreSQL | ✅ |
| Documentation build | ✅ |
| Signed Commits | ✅ |
| PR Compliance | ✅ |
The 8 failing checks are a `develop` infrastructure problem, not a problem
with this PR. Happy to rebase again once the upstream issues are resolved if
that helps move things forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
