AshharAhmadKhan commented on PR #5491: URL: https://github.com/apache/fineract/pull/5491#issuecomment-3985401101
@adamsaghy @IOhacker — pushed a fix for the two failing test-core-5 tests. **Root cause identified:** `ReportsTest.java` had two assertions written against the old data state that were never updated to reflect the intentional Pentaho removal. `listReports()` was asserting `hasSize(128)`. After removing 44 Pentaho-type reports from initial data, the runtime count is 76 (from 0002) + 8 (added by `0018_pentaho_reports_to_table.xml`) = 84. Updated to `hasSize(84)`. `runExpectedPaymentsPentahoReportWithoutPlugin()` was asserting status code 503 (Pentaho plugin not installed). The report `Expected Payments By Date - Formatted` has `report_type = Pentaho` and was correctly removed from initial data. With the report row gone, the API now returns 404 instead of 503. Updated the assertion to match the new correct behavior. Both changes are accurate reflections of the intentional data removal — the tests now document the post-Pentaho state rather than the legacy one. The API Backward Compatibility failure is a pre-existing upstream issue unrelated to this PR, present across all recent PRs since Feb 26. Ready for re-review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
