nidhiii128 opened a new pull request, #5562: URL: https://github.com/apache/fineract/pull/5562
## Description This PR modernizes the Staff API by replacing manual JSON Map parsing with a structured StaffRequest DTO and migrating date handling from the deprecated java.util.Date to the modern java.time.LocalDate. ## Key Changes Architectural Refactor: Moved StaffRequest from fineract-provider to fineract-core to allow for better separation of concerns and reuse across modules. Type Safety: Replaced Map<String, Object> in StaffWritePlatformService with the StaffRequest DTO, enabling compile-time checks and reducing runtime errors. Modern Date Handling: Updated the Staff entity, commands, and validators to use java.time.LocalDate, aligning with the project's goal to eliminate legacy date objects. Command Handling: Refactored CreateStaffCommandHandler and StaffCommandFromApiJsonDeserializer to leverage the new DTO structure. Test Alignment: Updated StaffTest.java and related integration tests (including Feign client tests) to ensure compatibility with the new API structure. ## Impact Improves code readability and maintainability. Simplifies the validation logic by using DTO-based constraints. Ensures consistent date/time behavior across different database engines (MariaDB/PostgreSQL). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
