nidhiii128 commented on PR #5562: URL: https://github.com/apache/fineract/pull/5562#issuecomment-3989137410
> ``` > Did you mean 'ClientIdentifierStatus statusEnum = ClientIdentifierStatus.valueOf(statusName.toUpperCase(Locale.ROOT));' or 'ClientIdentifierStatus statusEnum = ClientIdentifierStatus.valueOf(statusName.toUpperCase(Locale.getDefault()));' or 'ClientIdentifierStatus statusEnum = ClientIdentifierStatus.valueOf(Ascii.toUpperCase(statusName));'? > /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/organisation/staff/domain/StaffRequest.java:19: error: [PackageLocation] Expected package org.apache.fineract.organisation.staff.data to be declared in a directory ending with org/apache/fineract/organisation/staff/data, instead found org/apache/fineract/organisation/staff/domain > package org.apache.fineract.organisation.staff.data; > ``` hi @adamsaghy, I've addressed these two points in the latest push: Regarding toUpperCase(): I've updated the code to use Locale.ROOT. I understand now that using the default system locale can cause unexpected behavior with certain character sets (like the Turkish 'I'), so using Locale.ROOT ensures consistent, language-neutral behavior for the Enum lookup. Regarding StaffRequest.java: You were right the package declaration was still pointing to .data while the file was physically located in the .domain directory. I have corrected the package header to package org.apache.fineract.organisation.staff.domain; and updated all importing files to fix the compilation errors. All local Checkstyle and compilation tasks are now passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
