airajena commented on PR #5566: URL: https://github.com/apache/fineract/pull/5566#issuecomment-3986238120
> @airajena wrote: > > > I checked the failing ci checks, they are not related to version change, if it was then it should show concrete SQL/driver error. > > Thanks for checking. I understand and agree. > > We still need a passing build before merging. > > Otherwise this PR looks good to me. > > Did you figure out what was mucking with line endings for the `.adoc` files? Yes, repo has no .gitattributes rule enforcing .adoc line endings. git check-attr for those .adoc files returns no EOL attributes. Those files are expected as LF (git ls-files --eol shows i/lf). I have windows, so if any Windows tool saves with CRLF (for example a full-file rewrite API/editor default), Git sees the whole file as changed. That’s exactly the churn pattern we hit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
