meonkeys commented on code in PR #5566: URL: https://github.com/apache/fineract/pull/5566#discussion_r2873931753
########## fineract-doc/src/docs/en/chapters/testing/integration.adoc: ########## @@ -1,805 +1,805 @@ -= Integration Testing Review Comment: Ok, I'll look for your next push. Please let me know if you figure out what caused it. Spotless shouldn't change asciidoc files.. If every line was "changed", it's probably something related to (e.g. unix vs. windows) line endings. Ah, [maybe spotless is changing line endings](https://github.com/diffplug/spotless/tree/main/plugin-gradle#line-endings-and-encodings-invisible-stuff)? Based on the spotless config in the top-level `build.gradle` file it seems like it shouldn't, but I'm not familiar with spotless. I guess you'll be able to confirm on your end (e.g. running `git status`, `git diff`, etc. before and after running `spotlessApply`). Note that [git can change line endings](https://git-scm.com/docs/gitattributes.html#_eol), and IDEs certainly do it as well... that's more what I suspect. If what's in `build.gradle` applies to the asciidoc files, it looks like it should actually enforce unix line endings (`lineEndings 'UNIX'` under `spotless {}`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
