gyfora commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817602495
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -174,15 +159,17 @@ private void printCancelLogs(UpgradeMode upgradeMode,
String name) {
effectiveConfig);
JobStatus jobStatus = flinkApp.getStatus().getJobStatus();
jobStatus.setState("suspended");
- removeDeployment(flinkApp);
+
flinkApp.getStatus().setJobManagerDeploymentStatus(JobManagerDeploymentStatus.MISSING);
savepointOpt.ifPresent(jobStatus::setSavepointLocation);
return savepointOpt;
}
@Override
protected void shutdown(FlinkDeployment flinkApp, Configuration
effectiveConfig) {
- if (flinkApp.getStatus().getJobStatus() != null
- && flinkApp.getStatus().getJobStatus().getJobId() != null) {
+ if (org.apache.flink.api.common.JobStatus.RUNNING
Review comment:
I will add ignoreCase just to be safe and this needs to be hardened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
