bgeng777 commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817690157
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/FlinkDeploymentStatus.java
##########
@@ -26,6 +28,8 @@
@NoArgsConstructor
@AllArgsConstructor
public class FlinkDeploymentStatus {
- private JobStatus jobStatus;
+ private JobStatus jobStatus = new JobStatus();
Review comment:
Not a crucial one: having default value for `jobStatus` field or not
both make sense to me. But I am a little curious if there is any specific
reason for adding it here. If there is, maybe we can refactor
`createJobStatus()` in Observer.java to a static method here like
`parseFromJobMessage()`. Whatever, this one is not critical for this PR and we
can leave it as a followup if we hope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
