gyfora commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817734199
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/FlinkDeploymentStatus.java
##########
@@ -26,6 +28,8 @@
@NoArgsConstructor
@AllArgsConstructor
public class FlinkDeploymentStatus {
- private JobStatus jobStatus;
+ private JobStatus jobStatus = new JobStatus();
Review comment:
Having a default a jobstatus avoids a bunch of null checks, and also now
that you mention it I simplified the status update in a commit:
https://github.com/apache/flink-kubernetes-operator/pull/26/commits/d4924c0849976930d591a6f60ab77759a4582e5b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
