morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r821375790
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java
##########
@@ -20,25 +20,17 @@
import org.apache.flink.configuration.Configuration;
+import lombok.Value;
+
/** Configuration class for operator. */
+@Value
public class FlinkOperatorConfiguration {
private final int reconcileIntervalInSec;
private final int portCheckIntervalInSec;
- public FlinkOperatorConfiguration(int reconcileIntervalInSec, int
portCheckIntervalInSec) {
- this.reconcileIntervalInSec = reconcileIntervalInSec;
- this.portCheckIntervalInSec = portCheckIntervalInSec;
- }
-
- public int getReconcileIntervalInSec() {
- return reconcileIntervalInSec;
- }
-
- public int getPortCheckIntervalInSec() {
- return portCheckIntervalInSec;
- }
+ private final int savepointTriggerGracePeriodInSec;
Review comment:
indeed, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
