morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r821410732
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -101,12 +104,20 @@ public JobReconciler(
restoreFromLastSavepoint(flinkApp, effectiveConfig);
} else if (upgradeMode == UpgradeMode.LAST_STATE) {
final String savepointLocation =
-
flinkApp.getStatus().getJobStatus().getSavepointLocation();
+ flinkApp.getStatus()
+ .getJobStatus()
+ .getSavepointInfo()
+ .getLastSavepoint()
+ .getLocation();
// Upgrade mode changes from savepoint -> last-state
deployFlinkJob(
flinkApp, effectiveConfig,
Optional.ofNullable(savepointLocation));
}
}
+ ReconciliationUtils.updateForSpecReconciliationSuccess(flinkApp);
+ } else if (SavepointUtils.shouldTriggerSavepoint(flinkApp)) {
Review comment:
We cannot take a savepoint while reconciling the cluster, hence it is
separated to another reconcile loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
