SteNicholas commented on a change in pull request #48:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/48#discussion_r822172401
##########
File path:
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/observer/ObserverTest.java
##########
@@ -103,41 +99,43 @@ public void observeApplicationCluster() {
flinkService.setPortReady(false);
// Port not ready
- assertFalse(observer.observe(deployment, readyContext, conf));
+ observer.observe(deployment, readyContext, conf);
assertEquals(
JobManagerDeploymentStatus.DEPLOYING,
deployment.getStatus().getJobManagerDeploymentStatus());
- assertFalse(observer.observe(deployment, readyContext, conf));
+ observer.observe(deployment, readyContext, conf);
assertEquals(
JobManagerDeploymentStatus.DEPLOYING,
deployment.getStatus().getJobManagerDeploymentStatus());
flinkService.setPortReady(true);
// Port ready but we have to recheck once again
- assertFalse(observer.observe(deployment, readyContext, conf));
+ observer.observe(deployment, readyContext, conf);
assertEquals(
JobManagerDeploymentStatus.DEPLOYED_NOT_READY,
deployment.getStatus().getJobManagerDeploymentStatus());
// Stable ready
- assertTrue(observer.observe(deployment, readyContext, conf));
+ observer.observe(deployment, readyContext, conf);
assertEquals(
JobManagerDeploymentStatus.READY,
deployment.getStatus().getJobManagerDeploymentStatus());
+ assertEquals("RUNNING",
deployment.getStatus().getJobStatus().getState());
- assertTrue(observer.observe(deployment, readyContext, conf));
+ observer.observe(deployment, readyContext, conf);
assertEquals(
JobManagerDeploymentStatus.READY,
deployment.getStatus().getJobManagerDeploymentStatus());
+ assertEquals("RUNNING",
deployment.getStatus().getJobStatus().getState());
Review comment:
It's better to replace "RUNNING" with the `JobState.RUNNING.name()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
