morhidi commented on a change in pull request #48:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/48#discussion_r822410633
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##########
@@ -54,10 +56,19 @@ public Observer(FlinkService flinkService,
FlinkOperatorConfiguration operatorCo
this.operatorConfiguration = operatorConfiguration;
}
- public boolean observe(
- FlinkDeployment flinkApp, Context context, Configuration
effectiveConfig) {
+ public void observe(FlinkDeployment flinkApp, Context context,
Configuration effectiveConfig) {
+
observeJmDeployment(flinkApp, context, effectiveConfig);
- return isReadyToReconcile(flinkApp, effectiveConfig);
+ JobManagerDeploymentStatus deploymentStatus =
+ flinkApp.getStatus().getJobManagerDeploymentStatus();
+
+ if (deploymentStatus == JobManagerDeploymentStatus.READY
+ && flinkApp.getSpec().getJob() != null) {
Review comment:
We can consider introducing a JobObserver/SessionObserver pair too
similarly to JobReconciler/SessionReconciler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
