gyfora commented on a change in pull request #48:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/48#discussion_r822645293
##########
File path:
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java
##########
@@ -295,6 +302,113 @@ public void verifyStatelessUpgrade() {
assertEquals(null, jobs.get(0).f0);
}
+ @Test
+ public void testUpgradeNotReadyCluster() {
+ testUpgradeNotReadyCluster(TestUtils.buildSessionCluster(), true);
+
+ FlinkDeployment appCluster = TestUtils.buildApplicationCluster();
+ appCluster.getSpec().getJob().setUpgradeMode(UpgradeMode.STATELESS);
+ testUpgradeNotReadyCluster(appCluster, true);
+
+ appCluster = TestUtils.buildApplicationCluster();
+ appCluster.getSpec().getJob().setUpgradeMode(UpgradeMode.LAST_STATE);
+ testUpgradeNotReadyCluster(appCluster, true);
+
+ appCluster = TestUtils.buildApplicationCluster();
+ appCluster.getSpec().getJob().setUpgradeMode(UpgradeMode.SAVEPOINT);
+ testUpgradeNotReadyCluster(appCluster, false);
+ }
+
+ public void testUpgradeNotReadyCluster(FlinkDeployment appCluster, boolean
allowUpgrade) {
+ mockServer
Review comment:
I tried this now and this would work for the newly added tests as they
don't test anything, but for the events it doesn't seem to work for some
reason. The list doesn't give back events created earlier in the controller.
I will open a jira ticket to try to solve this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
