gyfora commented on a change in pull request #48:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/48#discussion_r822623850
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -169,16 +189,24 @@ private void printCancelLogs(UpgradeMode upgradeMode,
String name) {
}
}
- private Optional<String> cancelJob(
+ private Optional<String> suspendJob(
FlinkDeployment flinkApp, UpgradeMode upgradeMode, Configuration
effectiveConfig)
throws Exception {
- Optional<String> savepointOpt =
- flinkService.cancelJob(
-
JobID.fromHexString(flinkApp.getStatus().getJobStatus().getJobId()),
- upgradeMode,
- effectiveConfig);
+
+ Optional<String> savepointOpt = Optional.empty();
+ if (upgradeMode == UpgradeMode.STATELESS) {
+ shutdown(flinkApp, effectiveConfig);
+ } else {
+ String jobIdString =
flinkApp.getStatus().getJobStatus().getJobId();
+ savepointOpt =
+ flinkService.cancelJob(
+ jobIdString != null ?
JobID.fromHexString(jobIdString) : null,
Review comment:
The change you propose would simply delete running clusters including HA
data which would break both savepoint and last-state upgrade modes.
The problem currently is that we use the cancelJob call even in cases where
the job might not be running (in last-state mode). In these cases the Job id is
not used. We can improve this in the future but at least this seems to work
well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
