SteNicholas commented on a change in pull request #56:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/56#discussion_r825607262
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##########
@@ -75,12 +80,15 @@ private boolean isApplicationClusterReady(FlinkDeployment
dep) {
}
private void observeJmDeployment(
- FlinkDeployment flinkApp, Context context, Configuration
effectiveConfig) {
+ FlinkDeployment flinkApp,
+ Context context,
+ Configuration effectiveConfig,
+ boolean checkOnReady) {
FlinkDeploymentStatus deploymentStatus = flinkApp.getStatus();
JobManagerDeploymentStatus previousJmStatus =
deploymentStatus.getJobManagerDeploymentStatus();
- if (JobManagerDeploymentStatus.READY == previousJmStatus) {
+ if (JobManagerDeploymentStatus.READY == previousJmStatus &&
!checkOnReady) {
Review comment:
@tweise +1, the branch that the REST server to be ready is only covered
in `observe` method. The exception like `TimeoutException` doesn't need to call
`isJobManagerPortReady` to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
