SteNicholas commented on a change in pull request #56:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/56#discussion_r825608115
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##########
@@ -127,14 +136,26 @@ private void observeJmDeployment(
return;
}
}
+ // checking the pod is expensive; we only do it when the
deployment isn't ready
+ PodList jmPods = flinkService.getJmPodList(flinkApp,
effectiveConfig);
+ for (Pod pod : jmPods.getItems()) {
+ for (ContainerStatus cs :
pod.getStatus().getContainerStatuses()) {
+ ContainerStateWaiting csw = cs.getState().getWaiting();
+ if ("CrashLoopBackOff".equals(csw.getReason())) {
Review comment:
Could this check be `!StringUtils.isEmpty(csw.getReason()) &&
csw.getReason().toLowerCase().contains("CrashLoopBackOff".toLowerCase())`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
