wangyang0918 commented on a change in pull request #65:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/65#discussion_r827591600
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobObserver.java
##########
@@ -87,8 +87,8 @@ private void updateJobStatus(JobStatus status,
List<JobStatusMessage> clusterJob
status.setState(newJob.getJobState().name());
status.setJobName(newJob.getJobName());
status.setJobId(newJob.getJobId().toHexString());
- // track the start time, changing timestamp would cause busy
reconciliation
- status.setUpdateTime(String.valueOf(newJob.getStartTime()));
+ status.setStartTime(String.valueOf(newJob.getStartTime()));
+ status.setUpdateTime(String.valueOf(System.currentTimeMillis()));
Review comment:
The current javaoperatorsdk behavior is a little strange. When
`generationAwareEventProcessing` is configured to `false`, not `true`, then the
events will be filtered.
@gyfora This also makes me confused what's your purpose of the commit
a2412c0f2434d8005be12318ec347cbe60502753. Do we want to filter the events only
when `.spec` changed?
[1]. https://javaoperatorsdk.io/docs/features
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
