gyfora commented on a change in pull request #65:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/65#discussion_r827689393
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobObserver.java
##########
@@ -87,8 +87,8 @@ private void updateJobStatus(JobStatus status,
List<JobStatusMessage> clusterJob
status.setState(newJob.getJobState().name());
status.setJobName(newJob.getJobName());
status.setJobId(newJob.getJobId().toHexString());
- // track the start time, changing timestamp would cause busy
reconciliation
- status.setUpdateTime(String.valueOf(newJob.getStartTime()));
+ status.setStartTime(String.valueOf(newJob.getStartTime()));
+ status.setUpdateTime(String.valueOf(System.currentTimeMillis()));
Review comment:
GenerationAware here means that it is aware that we should only
reconcile if the generation (spec) changes. So it might be a bit confusing but
it seems to work :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
