wangyang0918 commented on a change in pull request #67:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r827817804
##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
################################################################################
---
{{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}
Review comment:
How could we create the ingress when `watchNamespaces` is not
configured? By default, the operator is watching all the namespaces, I am
afraid it still could not update the ingress rules when running in a different
namespace with operator.
All in all, I am suggesting to create the ingress in the java code, not the
helm chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
