morhidi commented on a change in pull request #67:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828879697
##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
################################################################################
---
{{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}
Review comment:
@wangyang0918 I've modified the basic logic accordingly. On Minikube it
looks good, not sure if I'll have the chance to test it on AWS for example:
```
k get ingress
NAME CLASS HOSTS ADDRESS
PORTS AGE
basic-ingress nginx basic-ingress.default.flink.k8s.io 192.168.49.2
80 30m
basic-ingress2 nginx basic-ingress2.default.flink.k8s.io 192.168.49.2
80 3m39s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
