wangyang0918 commented on a change in pull request #85:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/85#discussion_r835908862
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -202,17 +200,19 @@ private void printCancelLogs(UpgradeMode upgradeMode) {
effectiveConfig);
}
- private void suspendJob(
+ private JobState suspendJob(
FlinkDeployment flinkApp, UpgradeMode upgradeMode, Configuration
effectiveConfig)
throws Exception {
final Optional<String> savepointOpt =
internalSuspendJob(flinkApp, upgradeMode, effectiveConfig);
JobStatus jobStatus = flinkApp.getStatus().getJobStatus();
- jobStatus.setState(JobState.SUSPENDED.name());
Review comment:
I prefer to update the status as early as possible since we are pretty
sure the job has already been cancelled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
