Aitozi commented on a change in pull request #85:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/85#discussion_r835916020
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##########
@@ -245,6 +241,19 @@
JobSpec oldJob = oldSpec.getJob();
JobSpec newJob = newSpec.getJob();
+
+ if (lastReconciledSpec(deployment) != null
+ && ReconciliationUtils.triggerRestart(deployment)) {
+ if (newJob.getState() != JobState.RUNNING) {
+ return Optional.of(
+ String.format("Cannot restart job to %s state",
newJob.getState()));
+ }
+ if (oldJob.getState() != JobState.RUNNING) {
+ return Optional.of(
+ String.format("Cannot restart job in %s state",
oldJob.getState()));
+ }
+ }
Review comment:
@gyfora @wangyang0918 Thanks for your suggestion, I have removed the
validation accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
