gyfora commented on a change in pull request #131:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/131#discussion_r839209471
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobObserver.java
##########
@@ -46,14 +48,24 @@ public JobObserver(
}
@Override
- public void observe(FlinkDeployment flinkApp, Context context,
Configuration effectiveConfig) {
+ public void observe(FlinkDeployment flinkApp, Context context,
Configuration defaultConfig) {
Review comment:
I suggest we not pass the defaultConfig to the `observe` method but pass
the `DefaultConfig` to the Observer constructor directly. This way we can avoid
accidentally using the wrong config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
