bgeng777 edited a comment on pull request #131: URL: https://github.com/apache/flink-kubernetes-operator/pull/131#issuecomment-1084260784
@gyfora thanks for your advice. PTAL at the latest commit, which does 2 things: 1. Add a new parameter in the constructor of `BaseObserver` and remove the `effectiveConfig` parameter in the `Observer#observe()` interface. I did not directly use `DefaultConfig` class as it would introduce extra construction of `FlinkOperatorConfiguration`. Besides, `operatorConfiguration` and `flinkConfig` are for different purposes and such modification can increase the readability. 2. Follow above discusstion to factoring out common codes to the `BaseObserver` and adjust tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
