chaokunyang commented on code in PR #2798:
URL: https://github.com/apache/fory/pull/2798#discussion_r2450593281
##########
rust/fory-core/src/serializer/core.rs:
##########
@@ -1322,7 +1322,7 @@ pub trait StructSerializer: Serializer + 'static {
/// - Default returns empty vector (no fields)
/// - **Do not implement** for user types with custom serialization (EXT
types)
#[allow(unused_variables)]
- fn fory_fields_info(type_resolver: &TypeResolver) ->
Result<Vec<FieldInfo>, Error> {
+ fn fory_fields_info(type_resolver: &mut TypeResolver) ->
Result<Vec<FieldInfo>, Error> {
Review Comment:
should be immutable from the semantics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
