chaokunyang commented on code in PR #2798:
URL: https://github.com/apache/fory/pull/2798#discussion_r2450614858
##########
rust/tests/tests/compatible/test_basic_type.rs:
##########
@@ -512,20 +512,20 @@ fn auto_conv() {
let fory = Fory::default().compatible(true);
// serialize_non-null
let writer = Writer::default();
- let mut write_context = WriteContext::new_from_fory(writer, &fory);
+ let mut write_context = WriteContext::new_from_fory(writer,
&fory).unwrap();
serialize_non_null(&fory, &mut write_context);
// deserialize_nullable
let bytes = write_context.writer.dump();
let reader = Reader::new(bytes.as_slice());
- let mut read_context: ReadContext = ReadContext::new_from_fory(reader,
&fory);
+ let mut read_context: ReadContext = ReadContext::new_from_fory(reader,
&fory).unwrap();
Review Comment:
this method should not return error. it should always succeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
