chaokunyang commented on code in PR #2865:
URL: https://github.com/apache/fory/pull/2865#discussion_r2483276743
##########
rust/fory-derive/src/object/write.rs:
##########
@@ -249,6 +249,7 @@ pub fn gen_write_field(field: &Field, ident: &Ident,
use_self: bool) -> TokenStr
pub fn gen_write_data(fields: &[&Field]) -> TokenStream {
let write_fields_ts: Vec<_> = fields
.iter()
+ .filter(|field| !is_skip_field(field))
Review Comment:
We also need to skip fields in
```rust
fn fory_get_sorted_field_names() -> &'static [&'static str];
fn fory_fields_info()
```
##########
rust/fory-derive/src/object/write.rs:
##########
@@ -249,6 +249,7 @@ pub fn gen_write_field(field: &Field, ident: &Ident,
use_self: bool) -> TokenStr
pub fn gen_write_data(fields: &[&Field]) -> TokenStream {
let write_fields_ts: Vec<_> = fields
.iter()
+ .filter(|field| !is_skip_field(field))
Review Comment:
We also need to skip fields in
```rust
fn fory_get_sorted_field_names() -> &'static [&'static str];
fn fory_fields_info()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
