chaokunyang commented on code in PR #2865:
URL: https://github.com/apache/fory/pull/2865#discussion_r2483796729
##########
rust/fory-derive/src/object/util.rs:
##########
@@ -768,7 +768,12 @@ pub(crate) fn get_sorted_field_names(fields: &[&Field]) ->
Vec<String> {
}
pub(super) fn get_sort_fields_ts(fields: &[&Field]) -> TokenStream {
- let sorted_names = get_sorted_field_names(fields);
+ let filterd_fields: Vec<&Field> = fields
Review Comment:
Could we extract a method to get filtered fields Vec And reuse it in read
and write.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
