chaokunyang commented on code in PR #2917: URL: https://github.com/apache/fory/pull/2917#discussion_r2569154051
########## java/fory-core/src/main/java/org/apache/fory/serializer/FinalFieldReplaceResolveSerializer.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fory.serializer; + +import org.apache.fory.Fory; +import org.apache.fory.memory.MemoryBuffer; + +/** + * Serializer for class which 1) has jdk `writeReplace`/`readResolve` method defined, 2) is a final + * field of a class. //TODO do we ned to write the flag REPLACED_NEW_TYPE/REPLACED_SAME_TYPE even + * for the final field? + */ +@SuppressWarnings({"unchecked", "rawtypes"}) +public class FinalFieldReplaceResolveSerializer extends ReplaceResolveSerializer { + + public FinalFieldReplaceResolveSerializer(Fory fory, Class type) { + super(fory, type, true); Review Comment: super class will invoke : ``` public ReplaceResolveSerializer(Fory fory, Class type) { super(fory, type); refResolver = fory.getRefResolver(); classResolver = fory.getClassResolver(); // `setSerializer` before `newJDKMethodInfoCache` since it query classinfo from `classResolver`, // which create serializer in turn. // ReplaceResolveSerializer is used as data serializer for ImmutableList/Map, // which serializer is already set. classResolver.setSerializerIfAbsent(type, this); ``` `classResolver.setSerializerIfAbsent(type, this);` may set wrong serializer, could we add another protected contrcutore in parent class to pass `setSerializer` param and pass false here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
