mchernyakov commented on code in PR #2917:
URL: https://github.com/apache/fory/pull/2917#discussion_r2570040377
##########
java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java:
##########
@@ -851,6 +853,19 @@ public Serializer<?> getRawSerializer(Class<?> cls) {
return getOrUpdateClassInfo(cls).serializer;
}
+ @Internal
+ @CodegenInvoke
+ @Override
+ public Serializer<?> getRawSerializerFinalField(Class<?> cls) {
Review Comment:
which one is more preferable
```java
// BaseObjectCodecBuilder
....
private static final TypeRef<?> FINAL_FIELD_SERIALIZER_TYPE =
TypeRef.of(FinalFieldReplaceResolveSerializer.class);
...
// in private Expression getOrCreateSerializer(Class<?> cls, boolean isField)
newSerializerExpr =
new Expression.NewInstance(FINAL_FIELD_SERIALIZER_TYPE, foryRef,
fieldTypeExpr);
```
or
```java
// BaseObjectCodecBuilder
...
private static final TypeRef<?> FINAL_FIELD_SERIALIZER_TYPE =
TypeRef.of(FinalFieldReplaceResolveSerializer.class);
...
// in private Expression getOrCreateSerializer(Class<?> cls, boolean isField)
newSerializerExpr =
new Expression.StaticInvoke(
FinalFieldReplaceResolveSerializer.class,
"createSerializer",
FINAL_FIELD_SERIALIZER_TYPE,
foryRef,
fieldTypeExpr);
...
// FinalFieldReplaceResolveSerializer
...
@CodegenInvoke
public static FinalFieldReplaceResolveSerializer createSerializer(Fory
fory, Class type) {
return new FinalFieldReplaceResolveSerializer(fory, type);
}
...
```
?
##########
java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java:
##########
@@ -851,6 +853,19 @@ public Serializer<?> getRawSerializer(Class<?> cls) {
return getOrUpdateClassInfo(cls).serializer;
}
+ @Internal
+ @CodegenInvoke
+ @Override
+ public Serializer<?> getRawSerializerFinalField(Class<?> cls) {
Review Comment:
@chaokunyang which one is more preferable
```java
// BaseObjectCodecBuilder
....
private static final TypeRef<?> FINAL_FIELD_SERIALIZER_TYPE =
TypeRef.of(FinalFieldReplaceResolveSerializer.class);
...
// in private Expression getOrCreateSerializer(Class<?> cls, boolean isField)
newSerializerExpr =
new Expression.NewInstance(FINAL_FIELD_SERIALIZER_TYPE, foryRef,
fieldTypeExpr);
```
or
```java
// BaseObjectCodecBuilder
...
private static final TypeRef<?> FINAL_FIELD_SERIALIZER_TYPE =
TypeRef.of(FinalFieldReplaceResolveSerializer.class);
...
// in private Expression getOrCreateSerializer(Class<?> cls, boolean isField)
newSerializerExpr =
new Expression.StaticInvoke(
FinalFieldReplaceResolveSerializer.class,
"createSerializer",
FINAL_FIELD_SERIALIZER_TYPE,
foryRef,
fieldTypeExpr);
...
// FinalFieldReplaceResolveSerializer
...
@CodegenInvoke
public static FinalFieldReplaceResolveSerializer createSerializer(Fory
fory, Class type) {
return new FinalFieldReplaceResolveSerializer(fory, type);
}
...
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
