chaokunyang commented on code in PR #3021:
URL: https://github.com/apache/fory/pull/3021#discussion_r2616292769
##########
java/fory-core/src/main/java/org/apache/fory/type/Descriptor.java:
##########
@@ -89,6 +89,8 @@ public static void clearDescriptorCache() {
private final Method writeMethod;
private ForyField foryField;
private boolean nullable;
Review Comment:
Looks good to me, it's much cleaner anc elegant.
But the default Descriptor is build and cached statically, you need to
update `getAllDescriptorsMap/getFieldDescriptors` in
`ClassResolver/TypeResolver` to create new `Descriptor` with correct
`nullable/trackRef` config.
Could you implement that in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
