chaokunyang commented on code in PR #3021:
URL: https://github.com/apache/fory/pull/3021#discussion_r2616725645
##########
java/fory-core/src/main/java/org/apache/fory/builder/BaseObjectCodecBuilder.java:
##########
@@ -404,8 +404,15 @@ protected Expression serializeField(
Expression fieldValue, Expression buffer, Descriptor descriptor) {
TypeRef<?> typeRef = descriptor.getTypeRef();
boolean nullable = descriptor.isNullable();
+ boolean explicitRefTracking = descriptor.isTrackingRef();
Review Comment:
Does this mean user can nevr disable ref tracking for a field by:
```java
class Struct {
@ForyField(ref=false)
Bar bar;
}
```
##########
java/fory-core/src/main/java/org/apache/fory/builder/BaseObjectCodecBuilder.java:
##########
@@ -404,8 +404,15 @@ protected Expression serializeField(
Expression fieldValue, Expression buffer, Descriptor descriptor) {
TypeRef<?> typeRef = descriptor.getTypeRef();
boolean nullable = descriptor.isNullable();
+ boolean explicitRefTracking = descriptor.isTrackingRef();
Review Comment:
Does this mean user can never disable ref tracking for a field by:
```java
class Struct {
@ForyField(ref=false)
Bar bar;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
