chaokunyang commented on code in PR #3094:
URL: https://github.com/apache/fory/pull/3094#discussion_r2652296544
##########
java/fory-core/src/main/java/org/apache/fory/serializer/AbstractObjectSerializer.java:
##########
@@ -106,6 +107,17 @@ static Object readFinalObjectFieldValue(
} else {
fieldValue = refResolver.getReadObject();
}
+ } else if (Union.class.isAssignableFrom(
Review Comment:
Such checks are slow, fieldInfo ash a class id, you can set id to UNION so
we can compare by id directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
