chaokunyang commented on code in PR #3094:
URL: https://github.com/apache/fory/pull/3094#discussion_r2653226592
##########
rust/fory-derive/src/object/serializer.rs:
##########
@@ -165,7 +165,7 @@ pub fn derive_serializer(ast: &syn::DeriveInput, attrs:
ForyAttrs) -> TokenStrea
}
#[inline(always)]
- fn fory_actual_type_id(type_id: u32, register_by_name: bool,
compatible: bool) -> u32 {
+ fn fory_actual_type_id(type_id: u32, register_by_name: bool,
compatible: bool, xlang: bool) -> u32 {
Review Comment:
It's not in hotpath, add a new parameter is OK. Maybe we should remove this
method in future, and handle type id idrectly in type_resolver.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
