chaokunyang commented on code in PR #3094:
URL: https://github.com/apache/fory/pull/3094#discussion_r2653475399
##########
rust/fory-derive/src/util.rs:
##########
@@ -19,6 +19,149 @@ use proc_macro2::TokenStream;
use quote::{format_ident, quote};
use syn::{Field, Fields, GenericArgument, PathArguments, Type, TypePath,
TypeTraitObject};
+// MurmurHash3 implementation for compile-time hash computation in proc-macro.
+// This is a copy of the implementation from fory-core since proc-macro crates
Review Comment:
what do you mean this, fory-derive already used code under fory-core:
```rust
use fory_core::types::{TypeId, PRIMITIVE_ARRAY_TYPE_MAP};
use fory_core::util::ENABLE_FORY_DEBUG_OUTPUT;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
