chaokunyang commented on code in PR #3254:
URL: https://github.com/apache/fory/pull/3254#discussion_r2802061005
##########
java/fory-core/src/main/java/org/apache/fory/type/DispatchId.java:
##########
@@ -44,20 +44,21 @@ public class DispatchId {
public static final int TAGGED_INT64 = 9;
public static final int FLOAT32 = 10;
public static final int FLOAT64 = 11;
- public static final int UINT8 = 12;
- public static final int UINT16 = 13;
- public static final int UINT32 = 14;
- public static final int VAR_UINT32 = 15;
- public static final int UINT64 = 16;
- public static final int VAR_UINT64 = 17;
- public static final int TAGGED_UINT64 = 18;
- public static final int EXT_UINT8 = 19;
- public static final int EXT_UINT16 = 20;
- public static final int EXT_UINT32 = 21;
- public static final int EXT_VAR_UINT32 = 22;
- public static final int EXT_UINT64 = 23;
- public static final int EXT_VAR_UINT64 = 24;
- public static final int STRING = 25;
+ public static final int FLOAT16 = 12;
Review Comment:
This ID is wrong, here is current id def in main branch:
```
/** float8: an 8-bit floating point number. */
public static final int FLOAT8 = 16;
/** float16: a 16-bit floating point number. */
public static final int FLOAT16 = 17;
/** bfloat16: a 16-bit brain floating point number. */
public static final int BFLOAT16 = 18;
```
Same for Float16 array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
