chaokunyang commented on code in PR #3254:
URL: https://github.com/apache/fory/pull/3254#discussion_r2836930543
##########
java/fory-core/src/main/java/org/apache/fory/type/DispatchId.java:
##########
@@ -49,15 +49,16 @@ public class DispatchId {
public static final int UINT32 = 14;
public static final int VAR_UINT32 = 15;
public static final int UINT64 = 16;
- public static final int VAR_UINT64 = 17;
- public static final int TAGGED_UINT64 = 18;
- public static final int EXT_UINT8 = 19;
- public static final int EXT_UINT16 = 20;
- public static final int EXT_UINT32 = 21;
- public static final int EXT_VAR_UINT32 = 22;
- public static final int EXT_UINT64 = 23;
- public static final int EXT_VAR_UINT64 = 24;
- public static final int STRING = 25;
+ public static final int FLOAT16 = 17;
+ public static final int VAR_UINT64 = 18;
+ public static final int TAGGED_UINT64 = 19;
+ public static final int EXT_UINT8 = 20;
+ public static final int EXT_UINT16 = 21;
+ public static final int EXT_UINT32 = 22;
+ public static final int EXT_VAR_UINT32 = 23;
+ public static final int EXT_UINT64 = 24;
+ public static final int EXT_VAR_UINT64 = 25;
+ public static final int STRING = 26;
Review Comment:
java/fory-core/src/main/java/org/apache/fory/serializer/FieldGroups.java
also needs update to clarify Float16 as build-in fields and grouped into
primitive/boxed groups based whethther it's nullable.
java/fory-core/src/main/java/org/apache/fory/builder/BaseObjectCodecBuilder.java
also needs update to handle Flaot16 specially, you can start from
`serializePrimitiveField`
java/fory-core/src/main/java/org/apache/fory/serializer/AbstractObjectSerializer.java
may also needs updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
