chaokunyang commented on code in PR #3252:
URL: https://github.com/apache/fory/pull/3252#discussion_r2817160903
##########
rust/fory-core/src/types.rs:
##########
@@ -274,7 +274,7 @@ pub fn compute_string_hash(s: &str) -> u32 {
hash as u32
}
-pub static BASIC_TYPES: [TypeId; 33] = [
+pub static BASIC_TYPES: [TypeId; 34] = [
Review Comment:
`get_primitive_type_id` in `rust/fory-core/src/serializer/list.rs` also need
chanage. Please also add tests for float16 array and float16 vec. and update
array.rs and list.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
