AshharAhmadKhan commented on PR #3252: URL: https://github.com/apache/fory/pull/3252#issuecomment-3935168034
Hi @chaokunyang, I've addressed all your review comments: - ✅ Removed `testfile.txt` - ✅ Fixed `list.rs` `get_primitive_type_id` and `is_primitive_type` for `float16` - ✅ Wired all 3 P1 runtime paths: builtin resolver, `skip.rs`, and list primitive path - ✅ Updated `fory-derive/src/object/util.rs` to recognize `float16` in `PRIMITIVE_TYPE_NAMES`, `get_primitive_type_id`, `get_type_id_by_name`, and array type mapping - ✅ Added `Vec<float16>` and `[float16; N]` tests All Rust CI checks are passing ✅ The one failing check (`Python CI / windows-2022, 3.11`) is unrelated to this PR — Chocolatey failed to download Bazel 8.2.1 due to a `504 Gateway Timeout` from `community.chocolatey.org` (a transient infrastructure issue on the GitHub Actions runner). No code changes are involved. Ready for approval! 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
