Tyooughtul commented on code in PR #3381: URL: https://github.com/apache/fory/pull/3381#discussion_r2833253265
########## docs/guide/cpp/index.md: ########## @@ -137,25 +137,22 @@ See the [examples/cpp](https://github.com/apache/fory/tree/main/examples/cpp) di ```cpp #include "fory/serialization/fory.h" +#include <string> +#include <vector> using namespace fory::serialization; // Define a struct -class Person { +struct Person { Review Comment: I think the issue is that class members are private by default, but the code uses aggregate initialization Person{"Alice", 30, ...} . As far as I understand, aggregate initialization requires all members to be public, so I changed it to struct . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
