chaokunyang commented on code in PR #3381:
URL: https://github.com/apache/fory/pull/3381#discussion_r2890545820
##########
ci/tasks/cpp.py:
##########
@@ -42,3 +89,10 @@ def run(install_deps_only=False):
common.bazel(f"{test_command} {targets}")
logging.info("C++ CI tasks completed successfully")
+
+ # Run documentation example tests
+ if not skip_doc_tests:
+ try:
+ run_doc_example_tests()
+ except Exception as e:
+ logging.warning(f"Documentation example tests failed: {e}")
Review Comment:
This should not be an warning, it should raise Exception and let ci fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
