ayush00git commented on PR #3374:
URL: https://github.com/apache/fory/pull/3374#issuecomment-3961544826
Hii @Zakir032002
Thanks for pointing out the flows,
- The `ReadFromDeserializer` and returning a direct slice into the data
stream are wrongly implemented by me, thanks for suggesting the chnages to fix
them as well.
But i think you misunderstood the `ReadVarUint32Small7`. We already have a
check condition -
```bash
if len(b.data)-readIdx >= 5 {
}
```
If we are near a chunk boundary (less than 5 bytes remaining in the buffer),
the execution completely skips `continueReadVarUint32` and jumps straight to
`readVaruint36Slow`. I don't think this part need any changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
