chaokunyang commented on PR #3374: URL: https://github.com/apache/fory/pull/3374#issuecomment-3976444343
Thanks for adding stream deserialization support. I found two correctness issues while testing stream-backed buffers with small chunk readers: 1. does not call , so stream-backed buffers can return short/zero reads even when the underlying still has data. This breaks internal call paths that use (for example / type-def decode), and I can reproduce corrupted metastring bytes with + one-byte reader. 2. currently collapses all errors into , so non-EOF transport errors (e.g. connection reset) are reported as bounds errors and the original I/O cause is lost. Could you take a look at these before merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
