eyad-hazem-elmorsy commented on code in PR #3429:
URL: https://github.com/apache/fory/pull/3429#discussion_r2867560966
##########
python/pyfory/buffer.pyx:
##########
@@ -283,8 +283,10 @@ cdef class Buffer:
if length > 0:
self.c_buffer.write_bytes(&data[0], length)
- cpdef inline bytes read_bytes_and_size(self):
+ cpdef inline bytes read_bytes_and_size(self, int32_t max_binary_size=-1):
Review Comment:
Since we want to enforce `max_binary_size` for binary byte-length reads (as
mentioned in issue), should I move the size checking to `read_bytes()` method
before this line?
`cdef bytes py_bytes = PyBytes_FromStringAndSize(NULL, length)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
