chaokunyang commented on code in PR #3429:
URL: https://github.com/apache/fory/pull/3429#discussion_r2867664827
##########
python/pyfory/buffer.pyx:
##########
@@ -283,8 +283,10 @@ cdef class Buffer:
if length > 0:
self.c_buffer.write_bytes(&data[0], length)
- cpdef inline bytes read_bytes_and_size(self):
+ cpdef inline bytes read_bytes_and_size(self, int32_t max_binary_size=-1):
Review Comment:
So, we don't want to enforce binary byte-length reads, we only wanto to
avoid malicouse length to introuce OOM. So if there is no preallocation, there
should not be no such check. Because if no engought data to read from buffer,
buffer read PAI will raise exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
