chaokunyang commented on PR #3374: URL: https://github.com/apache/fory/pull/3374#issuecomment-4005405408
Some Design suggestions: - Keep fast-path varint checks purely remaining >= N; do not call fill(N) in the predicate. - Never pass nil error sinks to fill in decode methods that promise bounds errors. - Make DeserializeFromReader either strictly stateless (always reset buffer) or explicitly stateful and align it with InputStream semantics. - Remove InputStream.reader unless it is actually needed (or use it for invariants/validation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
